[users at i-scream] Re: [i-scream.org #129] [PATCH] finer grained filesystem stats

Roman Neuhauser neuhauser at sigpipe.cz
Tue May 31 08:47:49 BST 2005


# bugs at i-scream.org / 2005-04-16 14:20:25 +0100:
> On Thu, 2005-04-14 at 13:19 +0100, neuhauser at sigpipe.cz via RT wrote:
> > # neuhauser at sigpipe.cz / 2005-04-13 15:45:02 +0200:
> > >     Find the patch (run-tested on FreeBSD 4.10-STABLE and RHEL 3.0 u3)
> > >     attached, or at
> > >     http://codex.sigpipe.cz/misc/libstatgrab/sg_get_fs_stats,2.patch
> > 
> >     A new version with correct indentation characters in saidar.c can
> >     be found at
> >     http://codex.sigpipe.cz/misc/libstatgrab/sg_get_fs_stats,3.patch
> 
> This is looking better. My only concern is that this changes the API
> because you've changed the names of existing values in the structure.
> Whilst I'm not fussed at this stage about breaking the ABI, this is more
> of an issue.
> 
> Would you be able to make a patch that leaves the existing values alone
> and just adds new ones?
> 
> (Unless any of the other libstatgrab developers - that will get this
> mail - disagree with me?)

    Hello,

    has RT misfiled my reply sent on Apr 21st? I modified the patch
    as requested, and it can be found here:

    http://codex.sigpipe.cz/misc/libstatgrab/sg_get_fs_stats,4.patch

-- 
How many Vietnam vets does it take to screw in a light bulb?
You don't know, man.  You don't KNOW.
Cause you weren't THERE.             http://bash.org/?255991




More information about the users mailing list